Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9025 add caching options to wms background settings #9213

Merged
merged 2 commits into from
Jun 13, 2023
Merged

#9025 add caching options to wms background settings #9213

merged 2 commits into from
Jun 13, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR includes following changes:

  • add the wms cache options to background settings dialog
  • remove the style check for tile grid because it is not consistent

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#9025

What is the new behavior?

The wms background settings dialog shows the cache options

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Jun 9, 2023
@allyoucanmap allyoucanmap self-assigned this Jun 9, 2023
@allyoucanmap allyoucanmap linked an issue Jun 9, 2023 that may be closed by this pull request
WMS caching with custom scales #9025
Closed
2 tasks
@tdipisa tdipisa requested a review from offtherailz June 9, 2023 08:30
offtherailz
offtherailz requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple of issues, not sure they are bugs or desired behavior:

  • I enabled for natural earth layer on gs-stable this, and I notice this warning.
    image Anyway there is no way to uncheck this localization... Should we remove also this check, for instance?
  • The style check has been removed because there is no way to select it, right? The same issue regards the tile size anyway. And a way to configure these option(s) in the backgrounds should be good (especially tileSize for performance). Evaluate with @tdipisa this.
  • This may be caused a GeoServer bug, because of the space in the layer name, not sure. Trying to add as background CM BaseMap (first) and refreshing the tile to check if it is present, I have an error.
<ows:ExceptionReport xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:ows="http://www.opengis.net/ows" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.0.0" xsi:schemaLocation="http://www.opengis.net/ows https://gs-stable.geosolutionsgroup.com/geoserver/schemas/ows/1.0.0/owsExceptionReport.xsd">
<ows:Exception exceptionCode="NoApplicableCode">
<ows:ExceptionText>No such layer or layer group 'CM%20BaseMap'</ows:ExceptionText>
</ows:Exception>
</ows:ExceptionReport>

@tdipisa
Copy link
Member

tdipisa commented Jun 13, 2023

I would like to check one by one above points with you @allyoucanmap

@tdipisa
Copy link
Member

tdipisa commented Jun 13, 2023 •
edited
Loading

I enabled for natural earth layer on gs-stable this, and I notice this warning.
Anyway there is no way to uncheck this localization... Should we remove also this check, for instance?

This is due to the fact that the mentioned layer has been added from the catalog tool where Enable localized styles is active
Therefore, the warning visualized by the tool is correct

The style check has been removed because there is no way to select it, right? The same issue regards the tile size anyway. And a way to configure these option(s) in the backgrounds should be good (especially tileSize for performance). Evaluate with @tdipisa this.

This as well as the above are both connected and they should be part of a separated issue to improve the overall tool and so provide the layer settings (or part of them but using the same tool) also for WMS backgrounds. This issue needs some work also for design and cannot be done as part of this PR. I'm going to open a new issue for the future (see #9218)

This may be caused a GeoServer bug, because of the space in the layer name, not sure. Trying to add as background CM BaseMap (first) and refreshing the tile to check if it is present, I have an error.

This point I think is the only one that need to be checked @allyoucanmap

@tdipisa tdipisa mentioned this pull request Jun 13, 2023
Open
6 tasks
@allyoucanmap
Copy link
Contributor Author

allyoucanmap commented Jun 13, 2023 •
edited
Loading

This may be caused a GeoServer bug, because of the space in the layer name, not sure. Trying to add as background CM BaseMap (first) and refreshing the tile to check if it is present, I have an error.

@tdipisa @offtherailz

The cache check tries to create the wmts url using the workspace path if this is available.

It seems that it is not possible to request workspace specific capabilities in GeoSever when a layer name contains a space.
I was able to replicate it locally by renaming the topp:states layer to topp:united states

http://localhost:8080/geoserver/topp/united%20states/gwc/service/wmts?SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetCapabilities

error:

image

@tdipisa
Copy link
Member

tdipisa commented Jun 13, 2023 •
edited
Loading

This may be caused a GeoServer bug, because of the space in the layer name, not sure. Trying to add as background CM BaseMap (first) and refreshing the tile to check if it is present, I have an error.

@tdipisa @offtherailz

The cache check tries to create the wmts url using the workspace path if this is available.

It seems that it is not possible to request workspace specific capabilities in GeoSever when a layer name contains a space. I was able to replicate it locally by renaming the topp:states layer to topp:united states

http://localhost:8080/geoserver/topp/united%20states/gwc/service/wmts?SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetCapabilities

error:

image

Can you approve then @offtherailz?

@offtherailz offtherailz self-requested a review June 13, 2023 10:53
@offtherailz offtherailz merged commit 6e1896e into geosolutions-it:master Jun 13, 2023
@tdipisa
Copy link
Member

tdipisa commented Jun 13, 2023 •
edited
Loading

@ElenaGallo please test in DEV with priority.

@ElenaGallo
Copy link
Contributor

Test passed.

allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Jun 14, 2023
@allyoucanmap
geosolutions-it#9025 add caching options to wms background settings (g…
4767b35 
…eosolutions-it#9213)
offtherailz added a commit that referenced this pull request Jun 15, 2023
@allyoucanmap @offtherailz
[Backport c047-2023.01.xx] Fix #9025 & #9193 WMS caching with custom …
1c2a7fd 
…scales (#9222)

* #9025 WMS caching with custom scales (projection resolutions strategy) (#9168)

* Fix #9025 WMS caching with custom scales (custom resolutions strategy from WMTS) (#9184)

---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>

* Fix #9025 Available tile grids popup always reports mismatch in geostories and dashboards (#9196)

* Fix #9193 Add a cache options checks/info also for default WMS tile grid (#9195)

* Fix #9193 failing test (#9207)

* #9025 add caching options to wms background settings (#9213)

* fix failing tests

---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@allyoucanmap allyoucanmap

Labels
C047-CLEVELAND-METROPARKS-2022-SUPPORT enhancement
Projects
None yet
Milestone
2023.02.00
Development

Successfully merging this pull request may close these issues.

WMS caching with custom scales
4 participants
@allyoucanmap @tdipisa @ElenaGallo @offtherailz